Respect ExternalUrl for OAuth #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess another option is to have a "trust proxy" bool option which then trusts |
|
Thanks, i simply missed it.. |
|
Ah ok, np 😄 Thanks for creating the project! |
jiriks74
pushed a commit
to jiriks74/opengist
that referenced
this pull request
Apr 28, 2024
…rnal-url-config Respect ExternalUrl for OAuth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may be missing something, but is there a reason not to enforce the configured ExternalUrl for OAuth?
I had issues with the Host being
127:0:0:1:<service-port>behind nginx reverse proxy unless I overwrite the Host header (as mentioned in the README) but that feels less safe.(This is untested.)